[Differential] [Commented On] D4057: Reuse QAction and QMenu items on updates

[Kai Uwe Broulik]

broulik added a comment.


  With this updated patch I no longer get submenus in window decoration, with the previous revision it worked.

INLINE COMMENTS

> dbusmenuimporter.cpp:32
>  #include <QPointer>
>  #include <QSignalMapper>
>  #include <QTime>

Unused now

> dbusmenuimporter.cpp:85
>      QMenu *m_menu;
> -    typedef QMap<int, QPointer<QAction> > ActionForId;
> +    typedef QMap<int, QAction* > ActionForId;
>      ActionForId m_actionForId;

using ActionForid = QMap<int, QAction *>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4057

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, markg, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170111/55ddfeda/attachment.html>