[Differential] [Accepted] D3617: [Touchpad KCM] New KWin Wayland version

[Martin Gräßlin]

graesslin accepted this revision.
graesslin added a reviewer: graesslin.
graesslin added a comment.
This revision is now accepted and ready to land.


  code looks good to me modulo the one issue. I didn't check the qml side, though and hope the Plasma Qml experts did so.

INLINE COMMENTS

> kwinwaylandtouchpad.h:22
> +
> +#include <libinput.h>
> +

why an include of libinput.h? If you use that you also have to find libinput in CMake. Otherwise it won't compile on all systems.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3617

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #vdg, #plasma, #plasma_on_wayland, #kwin, graesslin
Cc: sebas, luebking, graesslin, knambiar, kwin, plasma-devel, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, andreaska, eliasp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/a76990f0/attachment.html>