[Differential] [Accepted] D4069: [Notes Applet] Reduce switch size and hide controls if too small

Marco Martin noreply at phabricator.kde.org
Tue Jan 10 15:22:55 UTC 2017


mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  ok for me, tough i think it can still be reworked a bit to clean it up generally

INLINE COMMENTS

> main.qml:235
>  
> +        readonly property int requiredWidth: 6 * toggleFormatBarButton.width + 6 * spacing
> +        readonly property bool showFormatButtons: width > requiredWidth

could instead those buttons be in a Row, and control the visibility of the whole row by its width rather than computing by hand the width of all buttons?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D4069

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/e222d443/attachment.html>


More information about the Plasma-devel mailing list