[Differential] [Commented On] D4070: Changes to global menu applet

[Kai Uwe Broulik]

broulik added a comment.


  > When applet is placed in a vertical panel force use the compact view.
  
  Why? We can show the buttons below each other if the user wants to

INLINE COMMENTS

> appmenuapplet.cpp:109
> +
> +void AppMenuApplet::setUseApplet()
> +{

I think update instead of set is better wording

> main.xml:13
>      </entry>
> +    <entry name="fullViewAvailable" type="Bool">
> +      <default>true</default>

Can't you just use the plugin in the config dialog to avoid this config madness?

> main.qml:71
> +        checked: checkable
> +        iconSource: useApplet ? i18n("application-menu") : i18n("emblem-warning")
>          onClicked: {

Don't use "emblem" icons - they are meant for "badges on top of files" for instance

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4070

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, davidedmundson
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/e03eab56/attachment-0001.html>