[Differential] [Commented On] D4062: Simplify AppMenu menu management

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Jan 10 12:43:10 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> appmenu.cpp:123
> +    if (m_menu && m_menu.data()->isVisible()) {
> +        m_menu.data()->hide();
>          return;

It has operator->() so data() shouldn't be neccessary here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4062

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/e7b921df/attachment.html>


More information about the Plasma-devel mailing list