[Differential] [Commented On] D4062: Simplify AppMenu menu management
Kai Uwe Broulik
noreply at phabricator.kde.org
Tue Jan 10 12:41:13 UTC 2017
broulik added inline comments.
INLINE COMMENTS
> kdbusimporter.h:50
> + QMenu *createMenu(QWidget *parent) override {
> + return new VerticalMenu(parent);
> + }
The VerticalMenu needs to be told the service name and object path of the menu, otherwise in hideMenu it can't emit "menuHidden(service, path)"
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4062
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/f3e143bf/attachment.html>
More information about the Plasma-devel
mailing list