[Differential] [Request, 48 lines] D4062: Simplify AppMenu menu management
David Edmundson
noreply at phabricator.kde.org
Tue Jan 10 11:37:19 UTC 2017
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Instead of having a menu from the importer and our custom vertical menu
then syncing entries we can simply use the factory method in
DBusMenuImporter to create our custom one from the start.
This makes memory management easier as we only need to worry about the
importer which implicitly owns the menu.
TEST PLAN
Ran in-window menu, everything worked for me perfectly.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4062
AFFECTED FILES
appmenu/appmenu.cpp
appmenu/appmenu.h
appmenu/kdbusimporter.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/1f9df9ac/attachment.html>
More information about the Plasma-devel
mailing list