[Differential] [Commented On] D4057: Reuse QAction and QMenu items on updates

[David Edmundson]

davidedmundson added a comment.


  > Also, i seem to be missing where you set DBUSMENU_PROPERTY_ID on an action (or it's done in d->createAction?).
  
  Yes, it's an existing thing set there.
  
  The map is also existing, and it's used for a few other entry points, especially DBusMenuImporter::getMenuById()
  
  I would do your thing in (3), but given this map is already needed, I may as well use it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4057

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: markg, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170110/00ea5ad2/attachment.html>