[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

Eike Hein noreply at phabricator.kde.org
Mon Jan 9 08:38:38 UTC 2017


hein added a comment.


  Thanks for the explanation. Thoughts:
  
  - Can you try { new Array() } or something instead of []? There's some confusion in QML between "QML list" and "JavaScript array", perhaps the prop notification works with an explicity array.
  
  - If this doesn't work either, please add a code comment explaining why updateHistory exists.
  
  - Perhaps instead of length = 0 assignments and calling updateHistory, just assigning a new Array would be cleaner?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3931

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, hein, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170109/ec01703c/attachment.html>


More information about the Plasma-devel mailing list