[Differential] [Request, 4 lines] D4033: Return valid string value for DescriptionRole in all models

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  A qml binding converting an empty QVariant to a string value will result
  in a warning:
  Unable to assign [undefined] to QString
  
  Which is apparently happening to this bug reporter, but not for other
  roles.
  
  Grepping all models shows 2 code paths where this could happen.
  
  BUG: 369783

TEST PLAN
  Kickoff/Kicker still open
  Couldn't reproduce the original bug.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4033

AFFECTED FILES
  applets/kicker/plugin/computermodel.cpp
  applets/kicker/plugin/recentcontactsmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170109/323646d6/attachment.html>