[Differential] [Commented On] D3822: use a native event filter to notice the screen was swapped

broulik (Kai Uwe Broulik) noreply at phabricator.kde.org
Sun Jan 8 14:33:32 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> screenpool.cpp:188
> +
> +    const xcb_query_extension_reply_t* reply = xcb_get_extension_data(QX11Info::connection(), &xcb_randr_id);
> +

Is that call to X really neccessary everytime? It's called constantly for all kinds of events. Also at least cache the QX11Info::connection() ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3822

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, sebas, davidedmundson, #plasma
Cc: broulik, pmuralidharan, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170108/e033aed9/attachment.html>


More information about the Plasma-devel mailing list