[Differential] [Changed Subscribers] D3088: [KDecoration] Restore application menu button

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> decoration.cpp:201
> +{
> +    static_cast<ApplicationMenuEnabledDecoratedClientPrivate *>(d->client->d.get())->requestShowApplicationMenu(rect, actionId);
> +}

I don't get this? We've replaced one ABI crash with throwing a runtime exception on calling a pure virtual, which isn't going to be much better.

We either want:

if d->metaObject() == ApplicationMenuEnabledDecoratedClientPrivate::staticMetaObject()

Or to make the methods in the other class non pure virtuals.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D3088

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: davidedmundson, sitter, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/e9eb2d6a/attachment.html>