[Differential] [Commented On] D3981: better clean up of duplicate containments

mart (Marco Martin) noreply at phabricator.kde.org
Thu Jan 5 14:19:24 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:1922
> Why are you doing this?

cont is being deleted there, i'm making sure it's not in m_desktopContainments anymore for not even an instant.
desktopContainmentDestroyed wasn't even called before as it's disconnecting the connection before destroying

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3981

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/6c94b066/attachment.html>


More information about the Plasma-devel mailing list