[Differential] [Request, 4 lines] D3981: better clean up of duplicate containments

mart (Marco Martin) noreply at phabricator.kde.org
Thu Jan 5 13:53:44 UTC 2017


mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  due to old multiscreen bugs, sometimes the appletsrc file
  gets polluted with a lot of containments with same activity id
  and lastScreen, in some cases even hundreds
  (see https://bugs.kde.org/show_bug.cgi?id=371858)
  in that case we can't be 100% sure what containment will be loaded
  at startup, leading to an herratical behavior.
  it was trying to clean up duplicates but wasn't really effective
  now base upon lastScreen (so we catch other activities as well)
  and manually remove the destroyed containment from
  m_desktopContainments (which may sole some multiscreen
  related bug, such as 371991)
  
  BUG:371858

TEST PLAN
  started a session with the corrupted appletsrc from the bugreport,
  file gets cleaned out of duplicates

REPOSITORY
  R120 Plasma Workspace

BRANCH
  phab/cleanupcontainments

REVISION DETAIL
  https://phabricator.kde.org/D3981

AFFECTED FILES
  shell/shellcorona.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170105/c849e985/attachment.html>


More information about the Plasma-devel mailing list