[Differential] [Requested Changes To] D3931: [Plasma folderview] Change behaviour of FolderModel::up

hein (Eike Hein) noreply at phabricator.kde.org
Tue Jan 3 08:17:12 UTC 2017


hein requested changes to this revision.
hein added a comment.
This revision now requires changes to proceed.


  (a) I don't like accumulating data in a cache that's never evicted and never changed for correctness. What if the hierarchy changes in the meantime? This is like a subtle bug trap.
  
  (b) It's "Up", not "Back". If there's no way up from a location then there's no way up. Maybe for links we should make it "Back", and just keep the previous URL around.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3931

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: chinmoyr, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170103/ef9e84a2/attachment.html>


More information about the Plasma-devel mailing list