Review Request 129753: search and replace old hardcoded types from plasmapkg2

Marco Martin notmart at gmail.com
Mon Jan 2 19:52:11 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129753/
-----------------------------------------------------------

Review request for Plasma and Aleix Pol Gonzalez.


Bugs: 374463
    http://bugs.kde.org/show_bug.cgi?id=374463


Repository: plasma-framework


Description
-------

there is a single difference between command line parameters of plasmapkg2 and kpackagetool5: plasmapkg2 had some hardcoded names like "theme", "plasmoid" etc.
kpackagetool5 requires the servicetype name to be passed instead. in order to stay compatible convert those parameter with the proper servicetype name.
it's parsing parameters by hand in order to just pass anything else without further parsing


Diffs
-----

  src/plasma/packagestructure/plasmathemepackage.cpp 94f0c5c 
  src/plasmapkg/main.cpp b61b2e5 

Diff: https://git.reviewboard.kde.org/r/129753/diff/


Testing
-------

installing themes from knewstuff works again


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170102/0fafeb86/attachment.html>


More information about the Plasma-devel mailing list