[Differential] [Changed Subscribers] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

anthonyfieroni (Anthony Fieroni) noreply at phabricator.kde.org
Mon Jan 2 12:54:48 UTC 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> iconapplet.cpp:235
> +        m_openWithActions.clear();
> +        delete m_openContainingFolderAction;
> +    }

Make it smart pointer or assign nullptr after deletion or you hit a crash below

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3905

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: anthonyfieroni, mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170102/65b33b54/attachment.html>


More information about the Plasma-devel mailing list