[Differential] [Request, 5 lines] D3911: [Containment Appearance] Make sure to always load a config view

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If StackView is empty, currentItem will be null and we would break all over the place.
  This can happen when you have a wallpaper without config, so "sourceFile" would stay empty and thus onSourceFileChanged wouldn't be triggered and we wouldn't load anything into our StackView.
  
  BUG: 360862
  FIXED-IN: 5.8.6

TEST PLAN
  Switching between wallpapers still works (minus the usual glitches of default values not being applied but that's a different story) and applying settings. I can now switch between Hunyango and Haenau no problem.
  
  Ideally this dialog was refactored to use onActivated instead of onCurrentIndexChanged and Component.onCompleted to populate itself etc etc but when I did something similar to applet config dialog, it broke various places relying on the fact that values change *after* creation, so let's go with this least invasive patch, for 5.8 series anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3911

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170101/eaac0547/attachment.html>