[Differential] [Commented On] D4845: Fix context menu button's icon size when on default DPI

David Rosca noreply at phabricator.kde.org
Tue Feb 28 17:49:54 UTC 2017


drosca added inline comments.

INLINE COMMENTS

> ListItemBase.qml:122
> +                            active: parent.hovered
> +                            colorGroup: parent.hovered || !parent.flat ? PlasmaCore.Theme.ButtonColorGroup : PlasmaCore.ColorScope.colorGroup
> +                        }

Do we really need this (we certainly don't need the `parent.flat` part)? It doesn't seem to change the icon at all.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4845

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: Zren, subdiff, drosca, broulik
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170228/86f177e0/attachment-0001.html>


More information about the Plasma-devel mailing list