[Differential] [Commented On] D4830: Adjust plasma-desktop to the new fallback prefixes

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Feb 28 15:22:26 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> TaskProgressOverlay.qml:46
>              imagePath: "widgets/tasks"
> -            prefix: calculatePrefix()
> -            onRepaintNeeded: prefix = calculatePrefix()
> -
> -            function calculatePrefix() {
> -                var prefix = TaskTools.taskPrefix("progress")
> -                if (!frame.hasElementPrefix(prefix)) {
> -                    prefix = TaskTools.taskPrefix("hover")
> -                }
> -                return prefix
> -            }
> +            prefix: [TaskTools.taskPrefix("progress"), TaskTools.taskPrefix("hover")]
>          }

Now you place an array inside of an array.

(btw knotifications has a unitylauncher test app where you can test this, e.g. `~/Projects/kf5-build/knotifications/tests/unitylaunchertest org.kde.dolphin --progress 50`)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170228/78feab28/attachment.html>


More information about the Plasma-devel mailing list