[Differential] [Changed Subscribers] D4830: Adjust plasma-desktop to the new fallback prefixes

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> TaskProgressOverlay.qml:46
>              imagePath: "widgets/tasks"
> -            prefix: calculatePrefix()
> -            onRepaintNeeded: prefix = calculatePrefix()
> -
> -            function calculatePrefix() {
> -                var prefix = TaskTools.taskPrefix("progress")
> -                if (!frame.hasElementPrefix(prefix)) {
> -                    prefix = TaskTools.taskPrefix("hover")
> -                }
> -                return prefix
> -            }
> +            prefix: ["progress", "hover"]
>          }

You don't take into account orientation here (south/north/west/...) which `TaskTools.taskPrefix` does

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4830

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170228/9c48d09b/attachment.html>