[Differential] [Request, 27 lines] D4832: Open the correct submenu in kwin menu when activating the Appmenu with a shortcut

David Edmundson noreply at phabricator.kde.org
Mon Feb 27 23:23:29 UTC 2017


davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Export actionForId as a method in menuImporter
  
  IDs are used in the low level API which the appmenu kded module wants to
  use directly.
  
  Fix arguments in itemActivationRequest
  
  We have a int actionId and a uint window timestamp in porting somehow
  these had got swapped and renamed. This now matches the relevant DBus
  signal they connect to.
  
  Open correct acton sub-menu on loading
  
  So pressing alt+e will open the edit menu immediately when showing the
  application menu.
  
  Also remove existing leftover code that did this which is using a member
  var which was previously never set.

TEST PLAN
  Had the relevant emit patch in plasma-integration
  Pressed alt+e, got the edit menu

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4832

AFFECTED FILES
  appmenu/appmenu.cpp
  appmenu/appmenu.h
  libdbusmenuqt/dbusmenuimporter.cpp
  libdbusmenuqt/dbusmenuimporter.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170227/b022f322/attachment.html>


More information about the Plasma-devel mailing list