[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Chris Holland noreply at phabricator.kde.org
Mon Feb 27 21:34:46 UTC 2017


Zren added a comment.


  Oh crap. I just realized the stringlist => string error caused the svg not to load at all. Which means it wouldn't detect the margins from the svg. Essentially causing it to not add any "padding". If I copy "use anchors instead of fillHeight  …" <https://github.com/KDE/plasma-framework/commit/cee709d054fb3daf8c91940520ebf7cdc0c6d492#diff-71d3ea86e1b476afc4b047d7b8a39a2b> which is the only other new commit, it's still too small.
  
  Does the "toolbutton-hover" svg have no padding? Might need someone else with 1x DPI with updated repos to test this.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170227/819ee548/attachment.html>


More information about the Plasma-devel mailing list