[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> ListItemBase.qml:98
>  
> -                PlasmaExtras.Heading {
> -                    id :textLabel
> -                    Layout.fillWidth: true
> -                    level: 5
> -                    opacity: 0.6
> -                    wrapMode: Text.NoWrap
> -                    elide: Text.ElideRight
> +                RowLayout {
> +                    PlasmaExtras.Heading {

Add Layout.fillWidth: true

> ListItemBase.qml:235
> +
> +        onStatusChanged: status == PlasmaComponents.DialogStatus.Closed ? contextMenuButton.checked = false : 0
> +

I would prefer if you rewrite it to normal `if`, it's not clear what this is doing at the first look.
Or maybe in ToolButton use `checked: contextMenu.status == PlasmaComponents.DialogStatus.Open`, not sure if it will work though.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4751

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, drosca, Zren
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170227/ece0d2e7/attachment-0001.html>