[Differential] [Changed Subscribers] D4781: Add Module class + disable advanced options when module-gconf is not loaded

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> modulemanager.cpp:83
> +    QTimer *updateModulesTimer = new QTimer(this);
> +    updateModulesTimer->setInterval(500);
> +    connect(updateModulesTimer, &QTimer::timeout, this, &ModuleManager::updateLoadedModules);

singleShot?

> modulemanager.cpp:129
> +    const auto &modules = Context::instance()->modules();
> +    for (int i = 0; i < modules.count(); ++i) {
> +        m_loadedModules.append(static_cast<Module*>(modules.objectAt(i))->name());

Iterator / range for? (Didn't look what modules() is, though)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4781

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170225/7fed63a1/attachment.html>