[Differential] [Commented On] D4732: [KCM] Rework design and structure

[David Rosca]

drosca added a comment.


  Sorry, I only noticed it now when I was trying to fix the binding loop.

INLINE COMMENTS

> Applications.qml:33
> +    ColumnLayout {
> +        width: scrollView.viewport.width
> +

There is now binding loop because this binding (also for other tabs), which makes the content width wrong when switching tabs.

> Applications.qml:37
> +
> +        Header {
> +            enabled: parent.appsPlayingAudio

This is missing Layout.fillWidth

> Applications.qml:87
> +        ListView {
> +            id: capturestreams
> +            model: PulseObjectFilterModel {

This doesn't have height, interactive, visible, spacing properties as other ListViews.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4732

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: subdiff, #plasma, #vdg, drosca
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mbohlender
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/65e3ecad/attachment.html>