[Differential] [Request, 126 lines] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

[Jonathan Marten]

marten created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This change improves the layout of the font hinting sub-dialogue of this KCM.  Previously there was no spacing around or between the GUI elements and the combo boxes did not line up:
  
  F2542184: fontskcm-hinting-settings-Dx-before.png <https://phabricator.kde.org/F2542184>
  
  Now the dialogue uses a QFormLayout (but left aligned as discussed in https://phabricator.kde.org/D2853) with style default spacing:
  
  F2542188: fontskcm-hinting-settings-Dx-after.png <https://phabricator.kde.org/F2542188>
  
  In addition some porting away from KDE4 support is done:
  
  KDialog -> QDialog
  KApplication -> QApplication
  KProcess -> QProcess
  KStandardDirs -> KSharedConfig
  KDoubleNumInput -> QDoubleSpinBox
  
  There is, however, some KDE4 porting still remaining to be done, since I'm not sure whether there are Frameworks equivalents to these at the moment:
  
  KGlobalSettings::emitChange(KGlobalSettings::FontChanged);
  KFontDialog::getFontDiff()

TEST PLAN
  Built plasma-desktop with  these changes, checked correct appearance and operation of Fonts KCM.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4740

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: marten, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170223/38461493/attachment.html>