[Differential] [Updated] D4718: support for auto-hidden windows to resize

Marco Martin noreply at phabricator.kde.org
Wed Feb 22 16:35:07 UTC 2017


mart marked an inline comment as done.
mart added inline comments.

INLINE COMMENTS

> luebking wrote in client.cpp:2086
> and if the geometry changes while it's (intentionally) not hidden?

i added a disconnect when it's back to electricnone, that should fix it?

> luebking wrote in screenedge.cpp:989
> sure the sanity check is now really superfluous?

this did: if the border is the same, don't bother to re-reserve it, just return.
however, the client geometry may have changed, making the current edge struct useless.

one thing it could be compared is the old client geometry associated to the current edge, but it's info that wasn't saved

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170222/6c2a0913/attachment.html>


More information about the Plasma-devel mailing list