[Differential] [Changed Subscribers] D4718: support for auto-hidden windows to resize

[Thomas Lübking]

luebking added inline comments.

INLINE COMMENTS

> client.cpp:2086
> +            m_edgeGeometryTrackingConnection = connect(this, &Client::geometryChanged, this, [this, border](){
> +                hideClient(true);
> +                ScreenEdges::self()->reserve(this, border);

and if the geometry changes while it's (intentionally) not hidden?

> geometry.cpp:2116
>      updateTabGroupStates(TabGroup::Geometry);
> +    qWarning()<<"gggg"<<x<<y;
>      emit geometryChanged();

*ggggough*

> screenedge.cpp:989
>              hadBorder = true;
> -            if ((*it)->border() == border) {
> -                if (!(*it)->isReserved()) {

sure the sanity check is now really superfluous?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4718

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170222/fe37167f/attachment-0001.html>