[Differential] [Commented On] D4705: Don't assume initialized if there are pending dbus replies

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In https://phabricator.kde.org/D4705#88274, @jgrulich wrote:
  
  > If secrets are requested then it should immediately return from initialize() and given that the kcm is not marked as initialized until we get reply. To me it appears that what you did shouldn't be necessary.
  
  
  initalize() can be called more than once though, this is what happens for me:
  
  - initialized() is called, secrets are requested
  - setConnection() is called, resets to uninitialized
  - initialized() is called again by setConnection(), requests secrets a 2nd time
  - first reply is received
  - setConnection() is called again, which calls initialize() which sets m_initialized to true (this is what causes the bug)
  - second reply is received

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D4705

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, jgrulich
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170221/fba0a684/attachment.html>