[Differential] [Requested Changes] D4703: move the view at the correct index at startup

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  The QML hack is fine, but it seems like you've written the C++ part without reading any of the existing code.

INLINE COMMENTS

> kcm.cpp:320
>      if (auto listView = m_quickView->rootObject()->findChild<QQuickItem*>("listView")) {
>          listView->setProperty("currentIndex", index.isValid() ? index.row() : -1);
>      }

We're doing the exact same logic here. Duplicating it without deleting this is definitely wrong.

It looks like this should work as we've loaded the model and the model is populated at startup.
However if it's not, just add a new int property on the listView.

Or at an absolute minimum delete this.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4703

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170221/2ca52896/attachment.html>