[Differential] [Changed Subscribers] D4675: Applet: Add configure button next to tabbar

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:299
> +            Layout.alignment: Qt.AlignBottom
> +            tooltip: i18n("Configure Volume Settings...")
> +            iconSource: "configure"

Just use

  plasmoid.action("configure").text

> main.qml:300
> +            tooltip: i18n("Configure Volume Settings...")
> +            iconSource: "configure"
> +            onClicked: {

Rather use `iconName`?

> main.qml:304
> +            }
>          }
>      }

Please also add e.g.

  Accessible.text: tooltip

since the button has no text

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4675

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170220/d3aa58c6/attachment.html>