[Differential] [Request, 36 lines] D4674: StreamRestore: Cache values in writeChanges until receiving change from pa

David Rosca noreply at phabricator.kde.org
Mon Feb 20 09:05:34 UTC 2017


drosca created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  pa_ext_stream_restore have only one function to change all its
  properties, so we need to cache values between clients changing
  StreamRestore properties and pulseaudio actually signaling the property
  was changed.
  
  Fixes correctly muting Notification Sounds stream in KCM when moving
  slider to 0 value, because in that moment the KCM first sets volume to 0
  and then immediately mute to true.

TEST PLAN
  Changing notification sounds volume with slider works correctlu now

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.9

REVISION DETAIL
  https://phabricator.kde.org/D4674

AFFECTED FILES
  src/streamrestore.cpp
  src/streamrestore.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170220/83eea457/attachment-0001.html>


More information about the Plasma-devel mailing list