[Differential] [Accepted] D4653: Make the ItemViewHeader more similar to Discover's Header design

[Marco Martin]

mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ItemViewHeader.qml:66
> +            id: rect
> +            color: page.isCurrentPage ? Kirigami.Theme.linkColor : Kirigami.Theme.disabledTextColor
> +            height: Kirigami.Units.smallSpacing

linkColor? is it actually a link? highlightColor makes more semantic sense and should be the same color iirc by default?

> ItemViewHeader.qml:91
>              verticalAlignment: Text.AlignBottom
> -            color: Kirigami.Theme.highlightedTextColor
> +            color: root.backgroundImage.status === Image.Ready ? Kirigami.Theme.highlightedTextColor : Kirigami.Theme.linkColor
>              opacity: 1

also here linkColor->highlightColor?

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4653

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170217/b3de6a8a/attachment-0001.html>