[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon
Christoph Feck
noreply at phabricator.kde.org
Fri Feb 17 03:47:31 UTC 2017
cfeck added inline comments.
INLINE COMMENTS
> main.cpp:62
> +
> + //Case 3: Fix password extraction from git after update to Plasma 5.9 in neon
> + QRegularExpression re3("^(Password|Username) for (.*?)[:] $");
So are these strings really specific to git? Also, it makes no sense to mention the Plasma version or distribution this bug appears, if you want some explanation, either add the specifics in the comment, or just reference the KDE bug number.
REPOSITORY
R105 KDE SSH Password Dialog
REVISION DETAIL
https://phabricator.kde.org/D4540
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: idekels, whiting, bbuch, mpyne, cfeck
Cc: broulik, bbuch, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170217/7b2ecca5/attachment.html>
More information about the Plasma-devel
mailing list