[Differential] [Commented On] D4606: don't show 0% when no battery

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4606#86236, @broulik wrote:
  
  > Does it even make sense to show this thing if there's no battery? We already show a cross on the icon then, don't we? Makes it a bit redundant. On the other hand it could be confusing to have the option checked but then have it not do anything – maybe the check box needs to be grayed out in case there's no battery.
  
  
  the idea was to stilòl have the badge show up to not make that option look "broken". tough also having the checkbox greyed out makes sense too

INLINE COMMENTS

> davidedmundson wrote in BadgeOverlay.qml:36
> what's this for?

to keep it large enough to keep it looking good

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4606

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170215/da7adf3a/attachment.html>