[Differential] [Accepted] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Accepted, but please make the minor mods I suggested if you can.

INLINE COMMENTS

> ContextMenu.qml:38
>  
> +    property bool showAllPlaces
> +

Maybe a dated C++ mindset, but I don't like having no initial value :/

> backend.cpp:205
> +
> +    if (!showAllPlaces && actions.count() > 7) {
> +        const int totalActionCount = actions.count();

Some comments to explain why 7 here and 5 below might be good.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3815

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma:_design, hein, #plasma
Cc: mart, colomar, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170214/6bca88eb/attachment.html>