[Differential] [Commented On] D4596: Figure out the GTK version instead of using a hardcoded one

[Rohan Garg]

garg added a comment.


  In https://phabricator.kde.org/D4596#85993, @lbeltrame wrote:
  
  > FTR, the reason this was not done at CMake time was to avoid depending on a development package (and associated dependencies like a compiler) to install something that's architecture-dependent. My first. local patch I made at the time used pkg_config, but it was discarded for this reason.
  >
  > Not that I have hard feelings about this, should this be changed, but I just wanted to outline the rationale for it at the time.
  
  
  Understood, though I fear that hard coding the default leads to broken GTK themeing when the default gtk version in breeze gtk (3.18) is older than what a system might have ( for eg. 3.20 and above ).
  
  This eliminates the ambiguity altogether.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D4596

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: garg
Cc: lbeltrame, apol, sitter, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170213/ea2ed218/attachment.html>