[Differential] [Requested Changes To] D4540: fix bug with git after update to Plasma 5.9 in neon

Benjamin Buch noreply at phabricator.kde.org
Fri Feb 10 10:34:04 UTC 2017


bbuch requested changes to this revision.
bbuch added a reviewer: bbuch.
bbuch added a comment.
This revision now requires changes to proceed.


  This doesn't work for Usernames and the resulting keyFile is different from the old behavior. (It contains the closing ": ")
  
  Please change the regular expression to:
  
    QRegularExpression re3("^(Password|Username) for (.*?)[:] $");
  
  and map the keyFile to:
  
    keyFile = match3.captured(2);
  
  Apart from that, thank you very much, great work! :-)
  
  I use git with german locals and it does work.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D4540

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: idekels, whiting, mpyne, bbuch
Cc: bbuch, cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170210/f9fa61d5/attachment.html>


More information about the Plasma-devel mailing list