[Differential] [Commented On] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

Martin Gräßlin noreply at phabricator.kde.org
Fri Feb 10 10:04:00 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> client.cpp:2086-2094
> +                const auto &screenGeometry = screens()->geometry(screen());
> +
> +                switch (border) {
> +                case ElectricTop:
> +                    if (geometry().top() == screenGeometry.top()) {
> +                        return;
> +                    }

I think we need to have some more checks here. Like only left if it's also the left most screen.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D4530

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #kwin
Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170210/adb2118d/attachment-0001.html>


More information about the Plasma-devel mailing list