[Differential] [Commented On] D4533: Avoid a crash on Kwin decoration KCM teardown

Christoph Feck noreply at phabricator.kde.org
Thu Feb 9 21:05:50 UTC 2017


cfeck added inline comments.

INLINE COMMENTS

> kcm.cpp:103
>      m_quickView->rootContext()->setContextProperty("_borderSizesIndex", 3); // 3 is normal
> -    m_quickView->rootContext()->setContextProperty("configurationModule", this);
> +    m_quickView->rootContext()->setContextProperty("leftButtons", m_leftButtons);
> +    m_quickView->rootContext()->setContextProperty("rightButtons", m_rightButtons);

while you are at it, QStringLiteral?

REVISION DETAIL
  https://phabricator.kde.org/D4533

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: cfeck, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170209/7a6dfbf9/attachment.html>


More information about the Plasma-devel mailing list