[Differential] [Request, 40 lines] D4535: Fix crash in Screen Locker KCM on teardown

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
  QWidget as a context item to QtQuick can crash. Especially as the
  engine's context property gets deleted whilst deleting the parent item.
  
  This patch reworks the code so that exposed properties go through a
  proxy QObject.
  
  CCBUG: 373628

TEST PLAN
  Pressing back whilst in the screenlocker KCM used to crash every time,
  now it doesn't.
  
  Also changed the wallpaper type, new settings appeared, I went from flat
  image to a specific wallpaper, and then locked my screen.

REPOSITORY
  R133 KScreenLocker

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4535

AFFECTED FILES
  kcm/kcm.cpp
  kcm/kcm.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170209/8e4535b0/attachment.html>