[Differential] [Request, 33 lines] D4533: Avoid a crash on Kwin decoration KCM teardown

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  As described in https://bugreports.qt.io/browse/QTBUG-57714  exposing a
  QWidget as a context item to QtQuick can crash. Especially as the
  engine's context property gets deleted whilst deleting the parent item.
  
  This patch reworks the code so that the models are exposed to QML
  directly rather than going through a QWidget.
  
  CCBUG: 373628

TEST PLAN
  Pressing back whilst in the decoration KCM used to crash every time, now it doesn't.
  I still have the buttons.

BRANCH
  scaling_final

REVISION DETAIL
  https://phabricator.kde.org/D4533

AFFECTED FILES
  kcmkwin/kwindecoration/kcm.cpp
  kcmkwin/kwindecoration/kcm.h
  kcmkwin/kwindecoration/qml/Buttons.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170209/33dda4cd/attachment-0001.html>