Review Request 128417: Retain original task button sort order when in manual sort mode and plasmashell restarts.

Xuân Baldauf xuan--2016--identity.kde.org at baldauf.org
Wed Feb 8 15:50:26 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128417/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 3:50 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

This is the first step towards not loosing the sort order of the task buttons in the task bar, even when plasmashell crashes and the user has a specific manual sort order. For now, we use the sort order imposed by the creation time (so the user can affect the sort order simply by ordering the creation of the windows).

Once this patch is successful, we can expand sort order storage by storing the manual sort order offset in the X window properties each time that offset changes. This will make plasmashell crashes less damaging to a user who prefers a certain task button sort order (for the duration of the X session).


Diffs
-----

  libtaskmanager/CMakeLists.txt 9c3e15e 
  libtaskmanager/tasksmodel.cpp bf37042 
  libtaskmanager/xwindowtasksmodel.h d24a7d5 
  libtaskmanager/xwindowtasksmodel.cpp c1e9495 

Diff: https://git.reviewboard.kde.org/r/128417/diff/


Testing
-------

Testing was performed under openSUSE 42.1 against KDE Plasma 5.7


Thanks,

Xuân Baldauf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170208/a0fb24c6/attachment.html>


More information about the Plasma-devel mailing list