[Differential] [Commented On] D4491: Let make taskmanager tooltip readable again

[Roman Gilg]

subdiff added a comment.


  Can you add screenshots on your 13.3 screen with and without this patch?
  
  I know at the moment the code on master is not perfect. But we have to find a solution, which doesn't change the current look of the text lines completely. The Heading class to my taste has too large margins for the tooltips.

INLINE COMMENTS

> ToolTipInstance.qml:96
>                  width: isWin ? textWidth : undefined
> -                height: theme.mSize(theme.defaultFont).height
> -                font.pointSize: -1
> -                font.pixelSize: height
> +                height: 1.1 * theme.mSize(theme.defaultFont).height
>                  elide: Text.ElideRight

When we improve the current code, in best case we want to get rid of "magic numbers" (like 1.1 and 0.9 below or the 0.75 in current code).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4491

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: anthonyfieroni, #plasma, #plasma:_design
Cc: broulik, subdiff, hein, plasma-devel, davidedmundson, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170208/baa19798/attachment.html>