[Differential] [Commented On] D4494: Part Revert "Trigger context menu on press" as this breaks xembedsniproxy

[David Edmundson]

davidedmundson added a comment.


  FFS. Phabricator is being mental twice in a row now and showing somethign completely different to what I have on my system.
  
  I'll just put it here as a comment.
  
  diff --git a/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml b/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  index f83eeab186..6df5407e2c 100644
  
  - a/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  
  +++ b/applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  @@ -78,6 +78,19 @@ AbstractItem {
  
        });
        break;
    }
  
  +        case Qt.RightButton: {
  +            var service = statusNotifierSource.serviceForSource(DataEngineSource);
  +            var operation = service.operationDescription("ContextMenu");
  +            operation.x = pos.x;
  +            operation.y = pos.y;
  +
  +            var job = service.startOperationCall(operation);
  +            job.finished.connect(function () {
  +                plasmoid.nativeInterface.showStatusNotifierContextMenu(job, taskIcon);
  +            });
  +
  +            break;
  +        }
  
    case Qt.MiddleButton:
        var service = statusNotifierSource.serviceForSource(DataEngineSource);
        var operation = service.operationDescription("SecondaryActivate");
  
  @@ -86,23 +99,10 @@ AbstractItem {
  
    operation.y = pos.y;
    service.startOperationCall(operation);
    break;
  
  +            break;
  
        }
    }
     
  
  - onContextMenu: {
  - var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0); -
  - var service = statusNotifierSource.serviceForSource(DataEngineSource);
  - var operation = service.operationDescription("ContextMenu");
  - operation.x = pos.x;
  - operation.y = pos.y; -
  - var job = service.startOperationCall(operation);
  - job.finished.connect(function () {
  - plasmoid.nativeInterface.showStatusNotifierContextMenu(job, taskIcon);
  - });
  - } - onWheel: { //don't send activateVertScroll with a delta of 0, some clients seem to break (kmix) if (wheel.angleDelta.y !== 0) {

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4494

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170208/d8b85494/attachment.html>