[Differential] [Request, 28 lines] D4494: Part Revert "Trigger context menu on press" as this breaks xembedsniproxy

David Edmundson noreply at phabricator.kde.org
Wed Feb 8 09:44:11 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This part reverts commit https://phabricator.kde.org/R120:b9af99140365c8c8cf4e3744af7e13b35c35fa18 which
  changes plasmoids and SNI items to activate on mouse release instead of
  mouse click.
  
  This messes with xembedsniproxy which is relaying the mouse press
  signals to the exembed client. Now at the time of relay, if the client
  application queries the mouse state itself it's going to be wrong and
  that breaks GTK.
  
  BUG: 375930

TEST PLAN
  Reproduced the issue with xchat before the patch
  Now that context menu worked.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D4494

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170208/ce2b5a94/attachment.html>


More information about the Plasma-devel mailing list