[Differential] [Request, 29 lines] D4488: [System Tray] Introduce "effectiveStatus" property and update visibility only when that changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of calling it in response to any of the properties it depends on.
  This also saves some calls to this function on startup (80 instead of 90 for me with 14 tray icons) and keeps plasmoids from shifting around just because their status changed from e.g. Active to AcceptingInput (like touchpad when it asks for whether you really want to disable touchpad with no mouse attached) although the item's effective visibility didn't actually change.
  
  BUG: 375112
  CCBUG: 365630
  FIXED-IN: 5.10.0

TEST PLAN
  - Disabling categories still completely hides items
  - Active/passive change still moves items from compact rep to popup and vice-versa
  - when touchpad applet asks for confirmation it no longer shifts around (used to move to the left-most (after notifications) position)
  
  (I noticed that we don't actually support the `HiddenStatus` for plasmoids anymore which was originally introduced for system tray for applets to completely hide themselves)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4488

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170207/8d2d5703/attachment.html>