[Differential] [Commented On] D4470: [User Switcher] Ungrab keyboard before trying to lock the screen

Martin Gräßlin noreply at phabricator.kde.org
Tue Feb 7 18:37:29 UTC 2017


graesslin added inline comments.

INLINE COMMENTS

> switchuserdialog.cpp:171
> +{
> +    setKeyboardGrabEnabled(false);
> +}

I highly suggest to explicitly xcb_flush here. Otherwise your request to ungrab the keyboard is racing with your DBus call to screenlocker. There is a chance that the screenlocker would try to grab before the ungrab got to the X server.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4470

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, graesslin, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170207/5e576561/attachment.html>


More information about the Plasma-devel mailing list