[Differential] [Request, 9 lines] D4472: [Calculator Runner] Port non-Qalculate codepath from QtScript to QtQml

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Feb 7 09:37:37 UTC 2017


broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  QtScript is deprecated and at least in this place it's a straight-forward port.
  The Qalculate code path also doesn't need it, so remove it from CMake there.

TEST PLAN
  Used the non-Qalculate code path and typed in some calculations and it seemed to behave exactly like the old one (e.g. yielding "Infinity" for some huge results etc…)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4472

AFFECTED FILES
  runners/calculator/CMakeLists.txt
  runners/calculator/calculatorrunner.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170207/20198a98/attachment.html>


More information about the Plasma-devel mailing list